Run something before another thing

Question

Created Mar ’21

Replies 39

Boosts 0

Views 2.3k

Participants 3

Hi,
I have this code that I need to run in the exact line order, but I can't figure out how to do it.

Things I have tried:
DispatchQueue Aysnc
completion handler functions

Code:

Code Block         let pickedCat = Int.random(in: 1...4)
        //print("picked cat: \(pickedCat)")
        if pickedCat == 1 {
            getRandomJokes()
            randomJoke.text = "Random Joke: \(self.DadJokes)"
            //print("Random Joke: \(self.DadJokes)")
        }else if pickedCat == 2 {
            getAssistantJokes()
            randomJoke.text = "Random Joke: \(self.AssistantJokes)"
            //print("Random Joke: \(self.AssistantJokes)")
        }else if pickedCat == 3 {
            getKnockKnockJokes()
            randomJoke.text = "Random Joke: \(self.KnockKnockJokes)"
            //print("Random Joke: \(self.KnockKnockJokes)")
        }else if pickedCat == 4 {
            getRandomJokes()
            randomJoke.text = "Random Joke: \(self.RandomJokes)"
            //print("Random Joke: \(self.RandomJokes)")
        }
        if randomJoke.text == "Random Joke: " {
            randomJoke.text = "Random Joke: Failed to connect to server"
        }

Answered by Mcrich23 in 668731022

I figured out that for my case, I can just call it and then wait 0.6 seconds and call it again. To wait blank seconds use (replace 0.6 with the wanted amount):

Code Block DispatchQueue.main.asyncAfter(deadline: .now() + 0.6) {
    // Put your code which should be executed with a delay here
}

Boost

Answer 1

Claude31 OP

Mar ’21

What do you want in order ?

pickedCat == 1 before 2, before 3 and before 4 ?

If so, the only thing that matters is how you set pickedCat. But you don't show this part of code…

0

Answer 2

Mcrich23 OP

Mar ’21

I need the function to run before it sets the text.

0

Answer 3

Claude31 OP

Mar ’21

I need the function to run before it sets the text.

Which function ? You don't show anything about it. How do you want anyone to guess ?

Please, explain properly what you need and provide relevant information, otherwise, it is impossible to help.

0

Answer 4

Mcrich23 OP

Mar ’21

I mean the

Code Block get_Jokes()

Function. This isn’t running before I set the text and I need it to.

0

Answer 5

Claude31 OP

Mar ’21

You mean. Sure.

But this func shows nowhere in the code you posted.

Is it that confidential that you cannot show useful code to help you ?

0

Answer 6

Mcrich23 OP

Mar ’21

Here is the DadJokes function, they are all the same except for some pass ins:

Code Block func getDadJokes() {
                let collectionRef = self.db.collection("jokes")
                let documentRef = collectionRef.document("Dad Jokes")
                documentRef.getDocument(completion: { documentSnapshot, error in
                    if let error = error {
                        print(error.localizedDescription)
                        return
                    }
                    countDadJokes = (documentSnapshot?.data()!.count)! + 1
                    //print("count = \(count)")
                })
                db.collection("jokes").document("Dad Jokes").addSnapshotListener { document, error in
                        
                    //check for error
                    if error == nil {
                        //check if document exists
                        if document != nil && document!.exists {
                            
                            if let Joke = document!.get("\(Int.random(in: 0...countDadJokes))") as? String {
                                self.DadJokes = Joke
                                print("Joke: \(self.DadJokes)")
                            }
                        }
                    }
                }
            }

0

Answer 7

Claude31 OP

Mar ’21

Thanks for showing.

However, I do not understand how this relates to your initial post.

And what is it you want to have in a specific order.

0

Answer 8

Mcrich23 OP

Mar ’21

I want it to:

Pick the category
Get count of the documents on firestore in that category
Randomly pick a document
display that document

0

Answer 9

OOPer OP

Mar ’21

Pick the category
Get count of the documents on firestore in that category
Randomly pick a document
display that document

Watching the definition of getDadJokes(), you are using asynchronous calls in #2 and #3.

So, you need to:

Do #3 in the completion handler of #2
Do #4 in the completion handler of #3

Things I have tried:
DispatchQueue Aysnc
completion handler functions

I guess you used completion handler functions wrongly.

0

Answer 10

Mcrich23 OP

Mar ’21

I haven’t really played with completion handlers, could you give me an example?

0

Answer 11

OOPer OP

Mar ’21

I haven’t really played with completion handlers, could you give me an example?

Sorry, but you haven't shown enough code to write some example.

0

Answer 12

Mcrich23 OP

Mar ’21

Here is the entire function:

Code Block         var countDadJokes = Int()
        var countAssistantJokes = Int()
        var countKnockKnockJokes = Int()
        var countRandomJokes = Int()
        func getDadJokes() {
                let collectionRef = self.db.collection("jokes")
                let documentRef = collectionRef.document("Dad Jokes")
                documentRef.getDocument(completion: { documentSnapshot, error in
                    if let error = error {
                        print(error.localizedDescription)
                        return
                    }
                    countDadJokes = (documentSnapshot?.data()!.count)! + 1
                    //print("count = \(count)")
                })
                db.collection("jokes").document("Dad Jokes").addSnapshotListener { document, error in
                        
                    //check for error
                    if error == nil {
                        //check if document exists
                        if document != nil && document!.exists {
                            
                            if let Joke = document!.get("\(Int.random(in: 0...countDadJokes))") as? String {
                                self.DadJokes = Joke
                                print("Joke: \(self.DadJokes)")
                            }
                        }
                    }
                }
            }
        func getAssistantJokes() {
            if countAssistantJokes == 0 {
                let collectionRef = self.db.collection("jokes")
                let documentRef = collectionRef.document("Assistant Jokes")
                documentRef.getDocument(completion: { documentSnapshot, error in
                    if let error = error {
                        print(error.localizedDescription)
                        return
                    }
                    countAssistantJokes = (documentSnapshot?.data()!.count)! + 1
                    //print("count = \(count)")
                })
                db.collection("jokes").document("Assistant Jokes").addSnapshotListener { document, error in
                        
                    //check for error
                    if error == nil {
                        //check if document exists
                        if document != nil && document!.exists {
                            
                            if let Joke = document!.get("\(Int.random(in: 0...countAssistantJokes))") as? String {
                                self.AssistantJokes = Joke
                                print("Joke: \(self.AssistantJokes)")
                            }
                        }
                    }
                }
            }
        }
        func getKnockKnockJokes() {
            if countDadJokes == 0 {
                let collectionRef = self.db.collection("jokes")
                let documentRef = collectionRef.document("Knock Knock Jokes")
                documentRef.getDocument(completion: { documentSnapshot, error in
                    if let error = error {
                        print(error.localizedDescription)
                        return
                    }
                    countKnockKnockJokes = (documentSnapshot?.data()!.count)! + 1
                    //print("count = \(count)")
                })
                db.collection("jokes").document("Knock Knock Jokes").addSnapshotListener { document, error in
                        
                    //check for error
                    if error == nil {
                        //check if document exists
                        if document != nil && document!.exists {
                            
                            if let Joke = document!.get("\(Int.random(in: 0...countKnockKnockJokes))") as? String {
                                self.KnockKnockJokes = Joke
                                print("Joke: \(self.KnockKnockJokes)")
                            }
                        }
                    }
                }
            }
        }
        func getRandomJokes() {
            if countDadJokes == 0 {
                let collectionRef = self.db.collection("jokes")
                let documentRef = collectionRef.document("Random Jokes")
                documentRef.getDocument(completion: { documentSnapshot, error in
                    if let error = error {
                        print(error.localizedDescription)
                        return
                    }
                    countRandomJokes = (documentSnapshot?.data()!.count)! + 1
                    //print("count = \(count)")
                })
                db.collection("jokes").document("Dad Jokes").addSnapshotListener { document, error in
                        
                    //check for error
                    if error == nil {
                        //check if document exists
                        if document != nil && document!.exists {
                            
                            if let Joke = document!.get("\(Int.random(in: 0...countRandomJokes))") as? String {
                                self.RandomJokes = Joke
                                print("Joke: \(self.RandomJokes)")
                            }
                        }
                    }
                }
            }
        }
        let pickedCat = Int.random(in: 1...4)
        //print("picked cat: \(pickedCat)")
        if pickedCat == 1 {
            getRandomJokes()
            randomJoke.text = "Random Joke: \(self.DadJokes)"
            //print("Random Joke: \(self.DadJokes)")
        }else if pickedCat == 2 {
            getAssistantJokes()
            randomJoke.text = "Random Joke: \(self.AssistantJokes)"
            //print("Random Joke: \(self.AssistantJokes)")
        }else if pickedCat == 3 {
            getKnockKnockJokes()
            randomJoke.text = "Random Joke: \(self.KnockKnockJokes)"
            //print("Random Joke: \(self.KnockKnockJokes)")
        }else if pickedCat == 4 {
            getRandomJokes()
            randomJoke.text = "Random Joke: \(self.RandomJokes)"
            //print("Random Joke: \(self.RandomJokes)")
        }
        if randomJoke.text == "Random Joke: " {
            randomJoke.text = "Random Joke: Failed to connect to server"
        }
    }

0

Answer 13

OOPer OP

Mar ’21

Here is the entire function:
Thanks for showing the additional codes, but to make things work well with completion handler patter, you may need to modify the caller side.

What is the method header for the lines let pickedCat = Int.random(in: 1...4);... and how are you calling it?

0

Answer 14

Mcrich23 OP

Mar ’21

What is the method header for the lines let pickedCat = Int.random(in: 1...4);...and how are you calling it?

I am calling it with the ifs and if elses below it.

0

Answer 15

OOPer OP

Mar ’21

Sorry, it may not be clear enough.

For example, the method header for lines if countAssistantJokes == 0 {;... is

Code Block         func getAssistantJokes() {

And the answer for how it is called would be:

Code Block         }else if pickedCat == 2 {
            getAssistantJokes()  //<-
            randomJoke.text = "Random Joke: \(self.AssistantJokes)"
            //print("Random Joke: \(self.AssistantJokes)")
        }else if pickedCat == 3 {

(Including more context would be welcome.)

Generally, you should better not pick up some fragments of codes, but better show whole method.

0