Post

Replies

Boosts

Views

Activity

Reply to SwiftUI gets stuck in a view update cycle when I pass down a Binding to a NavigationPath
Is that the case? I've never heard that before 🤔Do you have a link where this is stated/explained? That would make me rethink some of the architectural decisions in my app. I assumed the entire purpose of that modifier is to place it anywhere in a NavigationStack, even on sub-pages. I often encountered similar statements when searching for solutions to problems with NavigationStack. For example, here is the first link that I found now with the answer from Apple Engineer: https://forums.developer.apple.com/forums/thread/727307?answerId=749141022#749141022 Quote from the answer: move navigationDestination modifiers as high up in the view hierarchy. This is more efficient for the Navigation system to read up front than with potentially every view update. The problem with moving everything to ContentView is that you lose all modularity. ContentView would be tightly coupled with MiddleView, which is what I really want to avoid. After workarounding a number of problems with NavigationStack, I came to the following solution for myself, maybe it may be useful: do not use NavigationPath, only an array (depending on the OS version, there were different problems). place navigationDestination on the root view of NavigationStack. use a synchronized @State variable for the path (yes, as you said, would not like to use this, but the absence of unnecessary re-initializations / body calls calms me down) To solve the problem with modularization, you can use ViewBuilder or View for different parts of the path. Simplified example: import SwiftUI enum Destination: Hashable { case flow1(Flow1Destination) case flow2(Flow2Destination) } struct ContentView: View { @State var path: [Destination] = [] var body: some View { NavigationStack(path: $path) { RootView(path: $path) .navigationDestination(for: Destination.self) { destination in switch destination { case let .flow1(destination): Flow1FactoryView(destination: destination, path: $path, getDestination: { .flow1($0) }) case let .flow2(destination): Flow2FactoryView(destination: destination, path: $path, getDestination: { .flow2($0) }) } } } } } struct RootView: View { @Binding var path: [Destination] var body: some View { VStack { Button("Flow1") { path.append(.flow1(.details)) } Button("Flow2") { path.append(.flow2(.login)) } } .navigationTitle("Root") } } enum Flow1Destination: Hashable { case details case more } struct Flow1FactoryView<Destination: Hashable>: View { let destination: Flow1Destination @Binding var path: [Destination] let getDestination: (Flow1Destination) -> Destination var body: some View { switch destination { case .details: DetailsView(onShowMore: { path.append(getDestination(.more)) }) case .more: MoreView() } } } struct DetailsView: View { let onShowMore: () -> Void var body: some View { Button("Show more", action: onShowMore) } } struct MoreView: View { var body: some View { Text("No more") } } enum Flow2Destination: Hashable { case login case forgot } struct Flow2FactoryView<Destination: Hashable>: View { let destination: Flow2Destination @Binding var path: [Destination] let getDestination: (Flow2Destination) -> Destination var body: some View { switch destination { case .login: LoginView(onForgotPassword: { path.append(getDestination(.forgot)) }) case .forgot: ForgotView(onClose: { path.removeLast() }) } } } struct LoginView: View { let onForgotPassword: () -> Void var body: some View { VStack { Text("Login") Button("Forgot?", action: onForgotPassword) } } } struct ForgotView: View { let onClose: () -> Void var body: some View { Button("Forgot", action: onClose) } } #Preview { ContentView() }
Aug ’24
Reply to SwiftUI gets stuck in a view update cycle when I pass down a Binding to a NavigationPath
When using ObservableObject for such purposes, when passing a navigation path from it to NavigationStack, there is such a problem that there are many unnecessary calls to navigationDestination and unnecessary reinitialization of View from the entire path https://feedbackassistant.apple.com/feedback/14536210 Additionally, due to the presence of EnvironmentObject, most likely some operations occur that lead to a loop of this process. Also, it is better to move navigationDestination as close to NavigationStack as possible, i.e. it is better to move it from MiddleView to ContentView. An example according to your code: // This is literally empty @MainActor final class SomeEnvironmentObject: ObservableObject {} @MainActor final class Router: ObservableObject { @Published var path: NavigationPath = .init() } struct ContentView: View { @StateObject var router = Router() @State private var someEnvironmentObject = SomeEnvironmentObject() var body: some View { NavigationStack(path: $router.path) { Button("Show Middle View") { router.path.append(0) } .navigationDestination(for: Int.self) { destination in MiddleView(path: $router.path) } .navigationDestination(for: String.self) { destination in InnerView(path: $router.path) } } .environmentObject(someEnvironmentObject) } } struct MiddleView: View { @EnvironmentObject var someEnvironmentObject: SomeEnvironmentObject @Binding var path: NavigationPath var body: some View { Button("Show Inner View \(someEnvironmentObject.self)") { path.append("0") } } } struct InnerView: View { @Binding var path: NavigationPath var body: some View { Text("Inner View") } } But if you want to leave it the same, you can use the @State variable for the navigation path, which is synchronized with the path from the Navigator, this will also fix the problem for this particular case, and will reduce the number of unnecessary navigationDestination calls and reinitializations to zero (not on all OS versions), example: @main struct ExampleApp: App { @State var router = Router() var body: some Scene { WindowGroup { ContentView() .environmentObject(router) } } } // This is literally empty @MainActor final class SomeEnvironmentObject: ObservableObject {} @MainActor final class Router: ObservableObject { @Published var path: NavigationPath = .init() } struct ContentView: View { @State private var someEnvironmentObject = SomeEnvironmentObject() @State private var path = NavigationPath() var body: some View { NavigationStack(path: $path) { Button("Show Middle View") { path.append(0) } .navigationDestination(for: Int.self) { destination in MiddleView(path: $path) } } .environmentObject(someEnvironmentObject) .synchronize(path: $path) } } extension View { // Or pass Binding navigation path from Navigator in a parameter func synchronize(path: Binding<NavigationPath>) -> some View { modifier(NavigationPathSynchronizationModifier(path: path)) } } struct NavigationPathSynchronizationModifier: ViewModifier { @EnvironmentObject var router: Router // Or pass navigator path directly as a @Binding @Binding var path: NavigationPath func body(content: Content) -> some View { if #available(iOS 17.0, macOS 14.0, tvOS 17.0, watchOS 10.0, *) { content .onChange(of: path) { _, newValue in guard router.path != newValue else { return } router.path = newValue } .onChange(of: router.path) { _, newValue in guard path != newValue else { return } path = newValue } } else { content .onChange(of: path) { newValue in guard router.path != newValue else { return } router.path = newValue } .onChange(of: router.path) { newValue in guard path != newValue else { return } path = newValue } } } } struct MiddleView: View { @EnvironmentObject var someEnvironmentObject: SomeEnvironmentObject @Binding var path: NavigationPath var body: some View { Button("Show Inner View \(someEnvironmentObject.self)") { path.append("0") } .navigationDestination(for: String.self) { destination in InnerView(path: $path) } } } struct InnerView: View { @Binding var path: NavigationPath var body: some View { Text("Inner View") } }
Aug ’24
Reply to Even slight main thread congestion causes Alert to miss dismissals
You are right, it is just a workaround for this particular case, allowing to avoid constant calls to the body and Alert reinitializations. It turns out that when calling body, when reinitializing Alert, the connection with the AlertController, which is displayed, is somehow lost. Which leads to this problem. But it is unlikely that we need to wait for this problem fixes, since Alert is deprecated.
Aug ’24
Reply to Even slight main thread congestion causes Alert to miss dismissals
For this sample project just move out the counter Text to standalone View and pass Binding: struct CounterView: View { @Binding var counter: Int var body: some View { Text("Counter: \(counter)") .font(.caption) } } Then replace this: Text("Counter: \(counter)") .font(.caption) With: CounterView(counter: $counter) P.S. To understand the problem, add in the body: var body: some View { let _ = Self._printChanges() ...
Aug ’24