I have had this issue before - icloud eating my macbook pro desktop folders had I unwittingly add "desk top' to the icloud. Into icloud and un select desk top folders - all GONE!!!!
Long story short
on mac, open finder - look down left hand columb for iCloud Drive - opeon the iCloud Drive - in there are all the items eaten by icloud - just drag and drop onto your mac desk top - you now have reinstated to desk top
hope this helps .....