looping functions in swift

Please show enough code to see if there is something wrong in it. Your explanation is so conceptual and your code example is too simplified.

sure

its a lot but i thought it might be easier

if you have all the code

import UIKit
import MapKit
import CoreLocation
 
//Locationvariables
struct Location {
    let title: String
    let latitude: Double
    let longitude: Double
    let oHour: Float
    let cHour: Float
}
 
/////////////////////////

//set Locations
let locations = [
    Location(title: "TestPin1", latitude: 37.330117, longitude: -122.019916, timeA: 1200, timeB: 1300),
    Location(title: "TestPin2", latitude: 37.337761, longitude: -122.033006, timeA: 0, timeB: 1800)
]
 
/////////////////////////

//create custom Annotation
class customAnnotation: MKPointAnnotation {
    var isCollapsed = true
    var setNeedsToggle = false
}
 
//Timevariables
let date = Date()
let calendar = Calendar.current
let minutes = calendar.component(.minute, from: date)
let hour = calendar.component(.hour, from: date)
let Hour = hour*100 + minutes
 
var icon = ""
 
class ViewController: UIViewController, MKMapViewDelegate, CLLocationManagerDelegate {
 
    @IBOutlet var map: MKMapView!
    
    //userLocation [variables]
    let manager = CLLocationManager()
    
    func locationManager(_ manager: CLLocationManager, didUpdateLocations position: [CLLocation]) {
        let position = position[0]
        let span: MKCoordinateSpan = MKCoordinateSpanMake(0.1, 0.1)
        let myLocation: CLLocationCoordinate2D = CLLocationCoordinate2DMake(position.coordinate.latitude, position.coordinate.longitude)
        let region: MKCoordinateRegion = MKCoordinateRegionMake(myLocation, span)
        map.setRegion(region, animated: true)
        
        self.map.showsUserLocation = true
        
    }
    
    
    override func viewDidLoad() {
        super.viewDidLoad()
        // Do any additional setup after loading the view, typically from a nib.
        
        //userLocation [algorithm]
        manager.delegate = self
        manager.desiredAccuracy = kCLLocationAccuracyBest
        manager.requestWhenInUseAuthorization()
        manager.startUpdatingLocation()
        
        //Loop creating different Locations
        for location in locations {
            let annotation = customAnnotation()
            annotation.title = location.title
            annotation.coordinate = CLLocationCoordinate2D (latitude: location.latitude, longitude: location.longitude)
            let timeAInt= Int(location.timeA)
            let timeBInt= Int(location.timeB)
            if timeAInt... timeBInt~= Hour { icon = "testPin1" }
            else { icon = "testPin2" }
            map.addAnnotation(annotation)
        }
        self.map.delegate = self
    }
    
    func mapView(_ mapView: MKMapView, viewFor annotation: MKAnnotation) -> MKAnnotationView? {
        guard let annot = annotation as? customAnnotation else { return nil }
        
        if annotation is MKUserLocation {
            return nil
        }
        let annotationView = MKAnnotationView(annotation: annotation, reuseIdentifier: "customAnnotation")
        annotationView.image = UIImage(named: icon)
        annotationView.canShowCallout = true
        
        let rightButton = UIButton(type: .detailDisclosure)
        rightButton.setImage(UIImage(named: annot.isCollapsed ? "ic_showmore" : "ic_showless"), for: .normal)
        annotationView.rightCalloutAccessoryView = rightButton
        
        if (annot.isCollapsed) {
            annotationView.detailCalloutAccessoryView = nil
        }
        else {
            let label = UILabel(frame: CGRect(x: 0, y: 0, width: 200, height: 21))
            label.text = "Description Shown When Button is Tapped"
            label.font = UIFont.italicSystemFont(ofSize: 14.0)
            label.numberOfLines = 0
            annotationView.detailCalloutAccessoryView = label
            
            label.widthAnchor.constraint(lessThanOrEqualToConstant: label.frame.width).isActive = true
            label.heightAnchor.constraint(lessThanOrEqualToConstant: 90.0).isActive = true
        }
        return annotationView
    }
    
    func mapView(_ mapView: MKMapView, annotationView view: MKAnnotationView, calloutAccessoryControlTapped control: UIControl) {
        guard let oldAnnot = view.annotation as? customAnnotation else { return }
        
        let annotation = customAnnotation()
        annotation.title = oldAnnot.title
        annotation.coordinate = oldAnnot.coordinate
        annotation.setNeedsToggle = true
        
        if (oldAnnot.isCollapsed) {
            annotation.isCollapsed = false
        }
        
        mapView.removeAnnotation(oldAnnot)
        mapView.addAnnotation(annotation)
    }
    
    internal func mapView(_ mapView: MKMapView, didAdd views: [MKAnnotationView]) {
        for view in views {
            if let annotation = view.annotation as? customAnnotation, annotation.setNeedsToggle {
                mapView.selectAnnotation(annotation, animated: true)
                return
            }
        }
    }
    
    override func didReceiveMemoryWarning() {
        super.didReceiveMemoryWarning()
        // Dispose of any resources that can be recreated.
    }
}

i hope this helps!

Perfect thank you very much!

i will try your changes and see if it works

The code i have shown is my default code which shows the same image for every annotation

the problem i have described in my question ("apple-logo") appeared when i put all the functions inside the for-loop

i just wanted to describe a problem i had when trying to solve this

--> this is my latest code

Yep worked

thanks a lot