Error in the CoreDataCloudKitDemo sample?

Question

Created Nov ’20

Replies 2

Boosts 0

Participants 1

I'm looking at the sample code in the CoreDataCloudKitDemo. Doesn't the remove (duplicate tags) method here have a bug, since it is modifying a copy of the tags but not reassigning them to the post?

Code Block private func remove(duplicatedTags: [Tag], winner: Tag, performingContext: NSManagedObjectContext) {
    duplicatedTags.forEach { tag in
        defer { performingContext.delete(tag) }
        guard let posts = tag.posts else { return }
            
        for case let post as Post in posts {
            if let mutableTags: NSMutableSet = post.tags?.mutableCopy() as? NSMutableSet {
                if mutableTags.contains(tag) {
                    mutableTags.remove(tag)
                    mutableTags.add(winner)
                }
            }
        }
    }
}

Boost

Answer 1

tdc OP

Nov ’20

Replacing with

Code Block            for case let post as Post in posts {
        post.removeFromTags(tag)
        post.addToTags(winner)
}

seems to work, although I don't know if that is proper.

0

Answer 2

tdc OP

Jun ’21

FB9126666

0